Code review comment for lp:~therve/landscape-client/juju-env-info-2

Revision history for this message
Chris Glass (tribaal) wrote :

Nice! +1

[nitpick]
+ fd = open(juju_info, "w")
+ fd.write(json.dumps({"JUJU_ENV_UUID": "uuid1",
+ "JUJU_UNIT_NAME": "unit/0"}))
+ fd.close()

Would probably benefit from a context instead, just in case:

with open(juju_info, "w") as fd:
    fd.write(juju.dumps({...}))

But yeah, nitpick, feel free to ignore.

review: Approve

« Back to merge proposal