Nice! +1
[nitpick] + fd = open(juju_info, "w") + fd.write(json.dumps({"JUJU_ENV_UUID": "uuid1", + "JUJU_UNIT_NAME": "unit/0"})) + fd.close()
Would probably benefit from a context instead, just in case:
with open(juju_info, "w") as fd: fd.write(juju.dumps({...}))
But yeah, nitpick, feel free to ignore.
« Back to merge proposal
Nice! +1
[nitpick] json.dumps( {"JUJU_ ENV_UUID" : "uuid1",
+ fd = open(juju_info, "w")
+ fd.write(
+ "JUJU_UNIT_NAME": "unit/0"}))
+ fd.close()
Would probably benefit from a context instead, just in case:
with open(juju_info, "w") as fd: write(juju. dumps({ ...}))
fd.
But yeah, nitpick, feel free to ignore.