Merge lp:~therve/landscape-client/hyper-v-detection into lp:~landscape/landscape-client/trunk
Proposed by
Thomas Herve
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alberto Donato | ||||
Approved revision: | 594 | ||||
Merged at revision: | 593 | ||||
Proposed branch: | lp:~therve/landscape-client/hyper-v-detection | ||||
Merge into: | lp:~landscape/landscape-client/trunk | ||||
Diff against target: |
42 lines (+17/-1) 2 files modified
landscape/lib/tests/test_vm_info.py (+15/-1) landscape/lib/vm_info.py (+2/-0) |
||||
To merge this branch: | bzr merge lp:~therve/landscape-client/hyper-v-detection | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Donato (community) | Approve | ||
Geoff Teale (community) | Approve | ||
Review via email:
|
Description of the change
The detection is not awesome. It came after some investigation on an Azure guest. The only other thing we can do is using the VGA card, but it implies either calling an external tool or hardcode the PCI ids. I think it does the trick for now.
To post a comment you must log in.
+1 I was trying to think of another case where we could get a false positive on the VGA card vendor, but I can't think of one.