Code review comment for lp:~therve/landscape-client/fake-package-reporter

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Tahnks, +1!

[7]

+ result.addCallback(lambda x: self.handle_tasks())

Maybe this can just be

         result.addCallback(lambda x: self._store.clear_tasks())

and handle_task() can be dropped.

[8]

+ def __init__(self, package_store, package_facade, remote_broker, config):
+ super(FakeGlobalReporter, self).__init__(package_store, package_facade,
+ remote_broker, config)

Do we need this?

review: Approve

« Back to merge proposal