Code review comment for lp:~therve/landscape-client/configure-ping-time

Revision history for this message
Kevin McDermott (bigkevmcd) wrote :

Fairly simple change, the main reason this sat unfixed is because of the ComputerOfflineAlert.

Should we restrict the ping time to no more than 4 minutes? Otherwise it will trigger...

Or we need to do some work to either report it, or disable it or something.

Am happy enough with this fix, but it presents some problems for people using it (outside of load-testing).

review: Approve

« Back to merge proposal