Code review comment for lp:~therp-nl/web-addons/7.0-web_relativedelta

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

The hope part is modesty and the fact that I'm not sure that the day= parameter is handled correctly.

What is bad about the standard implementation:
- no weekday, so there's no chance to have filters for the current (calendar) week, next week, etc
- no datetimes, only date
- no hours, minute, second
- negative days are not properly implemented

For an example:
Just use relativedelta as usual, but without the drawbacks as described above

« Back to merge proposal