Merge lp:~therp-nl/web-addons/7.0-web_confirm_window_close into lp:~webaddons-core-editors/web-addons/7.0

[Stefan Rijnhart (Opener)]

[Nhomar - Vauxoo (nhomar)]

With the last change i tested on Safari, Chrome and Mozilla. It works perfectly as expected, i will proceed with the merge.

Good job dude.

review: Approve

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks for testing and the review! I think we agreed on a minimum review time of 5 calendar days (aka. 3 business days) on the community mailing list after our last discussion about this, so I am less happy with the quick merge. If anyone still wants to comment on this code, then let me at least promise to respond as if this proposal has not been merged yet.

[Nhomar - Vauxoo (nhomar)]

Ups, I didn't see the date, i jus clean the web-addons branch of mergeable
branches, if somebody is not happy i can revert it.

REgards.

2013/9/1 Stefan Rijnhart (Therp) <email address hidden>

> Thanks for testing and the review! I think we agreed on a minimum review
> time of 5 calendar days (aka. 3 business days) on the community mailing
> list after our last discussion about this, so I am less happy with the
> quick merge. If anyone still wants to comment on this code, then let me at
> least promise to respond as if this proposal has not been merged yet.
> --
>
> https://code.launchpad.net/~therp-nl/web-addons/7.0-web_confirm_window_close/+merge/183187
> You are reviewing the proposed merge of
> lp:~therp-nl/web-addons/7.0-web_confirm_window_close into lp:web-addons.
>

--
--------------------
Saludos Cordiales

Nhomar G. Hernandez M.
[phone]
Skype: nhomar00
Web-Blog: http://geronimo.com.ve
Servicios IT: http://vauxoo.com
Linux-Counter: 467724
Correos:
<email address hidden>
<email address hidden>
twitter @nhomar

=== added directory 'web_confirm_window_close'
=== added file 'web_confirm_window_close/__init__.py'
=== added file 'web_confirm_window_close/__openerp__.py'
--- web_confirm_window_close/__openerp__.py	1970-01-01 00:00:00 +0000
+++ web_confirm_window_close/__openerp__.py	2013-08-30 14:17:43 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Therp BV (<http://therp.nl>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Check for unsaved data when closing browser window',
+    'description': '''
+This addon will show a confirmation dialog when the user closes
+a window with an OpenERP form containing unsaved data.
+
+This functionality is browser dependent. Opera ignores it at all,
+while Firefox displays a generic confirmation message.
+
+This module is compatible with OpenERP 7.0.
+''',
+    'version': '7.0.1',
+    'author': 'Therp BV',
+    'category': 'Usability',
+    'website': 'https://launchpad.net/web-addons',
+    'license': 'AGPL-3',
+    'depends': [
+        'web',
+        ],
+    'js': [
+        'static/src/js/web_confirm_window_close.js'
+        ],
+}

=== added directory 'web_confirm_window_close/static'
=== added directory 'web_confirm_window_close/static/src'
=== added directory 'web_confirm_window_close/static/src/js'
=== added file 'web_confirm_window_close/static/src/js/web_confirm_window_close.js'
--- web_confirm_window_close/static/src/js/web_confirm_window_close.js	1970-01-01 00:00:00 +0000
+++ web_confirm_window_close/static/src/js/web_confirm_window_close.js	2013-08-30 14:17:43 +0000
@@ -0,0 +1,42 @@
+/* 
+
+   Copyright (C) 2013 Therp BV
+   License: GNU AFFERO GENERAL PUBLIC LICENSE
+            Version 3 or any later version
+
+*/
+
+openerp.web_confirm_window_close = function(instance) {
+
+    instance.web.FormView.include({
+        init: function(parent, dataset, view_id, options) {
+            res = this._super(parent, dataset, view_id, options);
+            instance.web.bus.on('report_uncommitted_changes', this, function(e) {
+                if (this.$el.is('.oe_form_dirty')) {
+                    e.preventDefault();
+                }
+            });
+            return res;
+        }
+    }),
+    
+    instance.web.WebClient.include({
+        warning_on_close: function() {
+            var $e = $.Event('report_uncommitted_changes');
+            instance.web.bus.trigger('report_uncommitted_changes', $e);
+            if ($e.isDefaultPrevented()) {
+        	return instance.web._t(
+    		    "You have unsaved data in this window. " +
+    			"Do you really want to leave?");
+            }
+        },
+
+        start: function() {
+            res = this._super();
+            $(window).on("beforeunload", _.bind(
+                this.warning_on_close, this));
+            return res;
+        }
+
+    });
+}