Code review comment for lp:~therp-nl/therp-backports/addons-6.1_lp882036_account_rounding

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I see that the proposed branch for lp:1025649 has a misleadingly simple diff. When I look at the individual revisions, I see that many more changes have been made, which are already merged. That is out of scope for this branch I admit.

Of course, the title of lp:1025649 does not match the exhaustive scope of the official MP. Furthermore, the reason that your change does not feature in the official MP for lp:1025649 is because a verbatim patch was already merged as a fix for lp:977300.

Nothing out of this mess should do any harm to the merit of your patch so I approve.

review: Approve

« Back to merge proposal