Merge lp:~therp-nl/therp-addons/7.0_lp1215631 into lp:~therp-nl/therp-addons/7.0
Proposed by
Ronald Portier (Therp)
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 82 | ||||
Proposed branch: | lp:~therp-nl/therp-addons/7.0_lp1215631 | ||||
Merge into: | lp:~therp-nl/therp-addons/7.0 | ||||
Diff against target: |
20 lines (+6/-4) 1 file modified
fetchmail_invoice/model/fetchmail_invoice.py (+6/-4) |
||||
To merge this branch: | bzr merge lp:~therp-nl/therp-addons/7.0_lp1215631 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefan Rijnhart (Opener) (community) | Approve | ||
Review via email:
|
Description of the change
Resubmit to merge with 7.0 branch.
Prevent crash of fetchmail invoice, when trying to retrieve default invoice partner.
To post a comment you must log in.
Thanks!
One thing: line 15 will never be reached, because get_object_ references raises ValueError if the data reference can not be found. You should catch this if you want to raise a more user friendly error than 'No such external ID defined'.