Server Environment And Tools

Code review comment for lp:~therp-nl/server-env-tools/7.0-add_email_template_conditional_attachment

  1. 7.0-add_email_template_conditional_attachment
  2. Merge into 7.0
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Graeme,

thank you for the review!

I checked generate_email() in email_template/email_template.py and like you say, it is impossible not to have a return value that is not an email dictionary so I prefer to leave it like this to reflect that. If this changes in the future we can adapt then.

As for your usability suggestion, I just committed this as I think this is a very welcome improvement. Thank you for bringing this up!

Reply

« Back to merge proposal