Code review comment for lp:~therp-nl/openupgrade-tools/7.0-add-database_cleanup

>
> Maybe should the purge delete the attachments or drop the relationship
> beforehand?
>

This is already what is done through these lines:

                attachment_ids = attachment_pool.search(
                    cr, uid, [('res_model', '=', line.name)], context=context)
                if attachment_ids:
                    attachment_pool.write(
                        cr, uid, attachment_ids, {'res_model': False},
                        context=context)

I have to figure out what happens.