Code review comment for lp:~therp-nl/openupgrade-server/7.0-lp1131653_check_recursion_fix_false_positives

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Amazing, thanks! I had already set this branch to 'work in progress' because my fix still had the original flaw under different circumstances. I'd like to work this out but I will not have the time now. Maybe if the overhead of the workaround (https://code.launchpad.net/~therp-nl/openupgrade-server/7.0-lp1131653_workaround/+merge/150071) starts to bother me...

As for lp:ocb-server, I cannot say that it is affected by this issue as I only ever encountered it in the OpenUpgrade process. Note that the bug was never reported before while the code has been around for some time.

« Back to merge proposal