Code review comment for lp:~therp-nl/openupgrade-server/7.0-deferred_steps
Revision history for this message
| Sylvain LE GAL (GRAP) (sylvain-legal) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Hi.
1/ About the _drop_column & _drop_table calls. I agree with the concept but I will not be able to reproduce the call to these functions after a migration. Can you detail me when the problems occurs ? (an example of table or field that OpenERP try to delete).
2/ deferred migration move & conditional call : agreed.
Remark :
diff, line 20. "Not dropping the table of model ..." --> "Not dropping the table or view of model ..."