Merge lp:~therp-nl/openupgrade-server/7.0-allow_view_breakage into lp:openupgrade-server

[Stefan Rijnhart (Opener)]

[Holger Brunn (Therp) (hbrunn)]

Maybe make it clearer in the message that this is an expected error and can safely be ignored in many cases?

review: Approve (code review)

[lp:~therp-nl/openupgrade-server/7.0-allow_view_breakage]

4620. By Stefan Rijnhart (Opener) on 2013-07-24

[IMP] Warning text

[Stefan Rijnhart (Opener) (stefan-opener)]

Good idea. Done.

=== modified file 'openerp/addons/base/ir/ir_ui_view.py'
--- openerp/addons/base/ir/ir_ui_view.py	2013-04-15 10:57:44 +0000
+++ openerp/addons/base/ir/ir_ui_view.py	2013-07-24 17:25:35 +0000
@@ -126,8 +126,12 @@
             fvg = self.pool.get(view.model).fields_view_get(cr, uid, view_id=view.id, view_type=view.type, context=context)
             return fvg['arch']
         except:
-            _logger.exception("Can't render view %s for model: %s", view.xml_id, view.model)
-            return False
+            # OpenUpgrade: do not break on unrenderable views
+            _logger.warn("Can't render view %s for model: %s. If you are "
+                         "migrating between major versions of OpenERP, "
+                         "this is to be expected (otherwise, do not run "
+                         "OpenUpgrade server).", view.xml_id, view.model)
+            return "<data/>"
 
     def _check_xml(self, cr, uid, ids, context=None):
         for view in self.browse(cr, uid, ids, context):