Merge lp:~therp-nl/openupgrade-addons/6.1_fix_base_contact_name into lp:openupgrade-addons/6.1

Proposed by Holger Brunn (Therp)
Status: Merged
Merged at revision: 6614
Proposed branch: lp:~therp-nl/openupgrade-addons/6.1_fix_base_contact_name
Merge into: lp:openupgrade-addons/6.1
Diff against target: 60 lines (+6/-17)
2 files modified
base_contact/base_contact.py (+3/-1)
base_contact/migrations/6.1.1.0/pre-migration.py (+3/-16)
To merge this branch: bzr merge lp:~therp-nl/openupgrade-addons/6.1_fix_base_contact_name
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Review via email: mp+140473@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'base_contact/base_contact.py'
--- base_contact/base_contact.py 2012-02-15 13:22:13 +0000
+++ base_contact/base_contact.py 2012-12-18 15:24:31 +0000
@@ -93,7 +93,7 @@
93 return bool(value == 1)93 return bool(value == 1)
9494
95 exists = table_exists(self._table)95 exists = table_exists(self._table)
96 super(res_partner_contact, self)._auto_init(cr, context)96 result=super(res_partner_contact, self)._auto_init(cr, context)
9797
98 if not exists:98 if not exists:
99 cr.execute("""99 cr.execute("""
@@ -108,6 +108,8 @@
108 cr.execute("update res_partner_address set contact_id=id")108 cr.execute("update res_partner_address set contact_id=id")
109 cr.execute("select setval('res_partner_contact_id_seq', (select max(id)+1 from res_partner_contact))")109 cr.execute("select setval('res_partner_contact_id_seq', (select max(id)+1 from res_partner_contact))")
110110
111 return result
112
111res_partner_contact()113res_partner_contact()
112114
113class res_partner_location(osv.osv):115class res_partner_location(osv.osv):
114116
=== modified file 'base_contact/migrations/6.1.1.0/pre-migration.py'
--- base_contact/migrations/6.1.1.0/pre-migration.py 2012-06-19 09:34:23 +0000
+++ base_contact/migrations/6.1.1.0/pre-migration.py 2012-12-18 15:24:31 +0000
@@ -23,31 +23,18 @@
23import logging23import logging
24from openerp.openupgrade import openupgrade24from openerp.openupgrade import openupgrade
2525
26logger = logging.getLogger('OpenUpgrade')
27me = __file__
28
29
30def _migrate_last_name(cr):26def _migrate_last_name(cr):
31 column_renames = {27 column_renames = {
32 'res_partner_contact': [28 'res_partner_contact': [
33 ('name', 'last_name'),29 ('name', 'last_name'),
34 ],30 ],
35 }31 }
36 #if openupgrade.table_exists(cr, 'res_partner_contact'):
37 # return
38 #if not openupgrade.column_exists(cr, 'res_partner_contact', 'last_name'):
39 # return
40 openupgrade.rename_columns(cr, column_renames)32 openupgrade.rename_columns(cr, column_renames)
4133
42def _migrate_birthdate(cr):34def _migrate_birthdate(cr):
43 openupgrade.logged_query(cr, 'alter table res_partner_contact alter column birthdate type character varying(64);')35 openupgrade.logged_query(cr, 'alter table res_partner_contact alter column birthdate type character varying(64);')
4436
37@openupgrade.migrate()
45def migrate(cr, version):38def migrate(cr, version):
46 if not version:39 _migrate_last_name(cr)
47 return40 _migrate_birthdate(cr)
48 try:
49 logger.info("%s called", me)
50 _migrate_last_name(cr)
51 _migrate_birthdate(cr)
52 except Exception, e:
53 raise osv.except_osv("OpenUpgrade", '%s: %s' % (me, e))

Subscribers

People subscribed via source and target branches