Merge lp:~therp-nl/openobject-server/7.0-lp1287204-module_icon_field_length into lp:openobject-server/7.0

Proposed by Stefan Rijnhart (Opener) on 2014-03-03
Status: Needs review
Proposed branch: lp:~therp-nl/openobject-server/7.0-lp1287204-module_icon_field_length
Merge into: lp:openobject-server/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
openerp/addons/base/base.sql (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/openobject-server/7.0-lp1287204-module_icon_field_length
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza (community) code review and test Approve on 2014-04-25
OpenERP Core Team 2014-03-03 Pending
Review via email: mp+209083@code.launchpad.net

Description of the change

Align the field length of the module icon in base.sql to that of the field length in the model definition, to prevent probblems with modules with longer technical names (>40) that have an icon in the conventional location 'static/src/img/icon.png'

To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

Works as expected.

Regards.

review: Approve (code review and test)

Unmerged revisions

5251. By Stefan Rijnhart (Opener) on 2014-03-03

[FIX] Adapt field length in base.sql to corresponding field length in orm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openerp/addons/base/base.sql'
--- openerp/addons/base/base.sql 2012-12-17 21:46:45 +0000
+++ openerp/addons/base/base.sql 2014-03-03 15:06:16 +0000
@@ -286,7 +286,7 @@
286 name character varying(128) NOT NULL,286 name character varying(128) NOT NULL,
287 author character varying(128),287 author character varying(128),
288 url character varying(128),288 url character varying(128),
289 icon character varying(64),289 icon character varying(128),
290 state character varying(16),290 state character varying(16),
291 latest_version character varying(64),291 latest_version character varying(64),
292 shortdesc character varying(256),292 shortdesc character varying(256),