Code review comment for lp:~therp-nl/openobject-addons/7.0-addons_lp985525-wrong-bom-test

Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

Changed status to work in progress, because rethinking the problem the solution is not bullet proof.

My code guards against creating recursion by adding a product on a bom line that is among the ancestors (following bom_id) of that line.

But recursion can also be caused by creating a containing bill of material that has the product somewhere as a component among its descendents. I think that is the problem the original code tried (in the wrong way) to solve.

Even creating an "in between" bill of material, might cause recursion if it has some product somewhere both on the way up, or the way down.

« Back to merge proposal