Code review comment for lp:~therp-nl/openerp-web/lp1179839
Revision history for this message
| Holger Brunn (Therp) (hbrunn) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
I talk about empty attrs (meaning, no create/delete/edit properties in attrs) because this is what you end up with if you don't define this attributes on your form/tree view. Then there is no difference between the override I would like to delete in this MP (which breaks setting those attributes on many2many fields) and the one defined in forms.js. I would like to understand which check you think the original function breaks.
To sum up: I think the function is_action_enabled only is about the UI telling whether or not the developer writing a form wants to have certain buttons there, which has nothing to do with the underlying access rights. Do we agree on that? And if so, why do we still need to disable that for m2m fields?