Code review comment for lp:~therp-nl/openerp-web/lp1179839

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

I just made a test with a user without create rights for users. Opened a group with it and its user_ids' many2many attrs has none of those attributes set. Are you talking about a feature in current trunk maybe? But also there I don't see any difference.

The original version of is_action_enabled does that:

is_action_enabled: function(action) {
        var attrs = this.fields_view.arch.attrs;
        return (action in attrs) ? JSON.parse(attrs[action]) : true;
    }
http://bazaar.launchpad.net/~openerp/openerp-web/7.0/view/head:/addons/web/static/src/js/views.js#L1464

so I don't see how that changes anything for an empty attrs?

« Back to merge proposal