Code review comment for lp:~therp-nl/ocb-server/7.0_lp1260743_print_empty_lines

Revision history for this message
Olivier Laurent (Acsone) (olivier-laurent) wrote :

> Thanks! This actually improves on https://code.launchpad.net/~olivier-laurent
> /openobject-server/6.1-bug1157048/+merge/154031, which either only works in
> other cases or has only worked before.

Just FYI... my proposal was based on reportlab 2.5. A behaviour change in reportlab 2.6 made this proposal without effects !

Tested with the 2 versions of reportlab.

(with version 2.6, "technical" blank lines of the rml template are also removed rendering the pdf result less clear !)

review: Approve

« Back to merge proposal