Code review comment for lp:~therp-nl/ocb-addons/lp754339
Revision history for this message
| Holger Brunn (Therp) (hbrunn) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
In principle, I agree with Lionel.
Two arguments for putting this into ocb rather than into a module
- doing this in a module most likely won't work well with other modules that fiddle with the onchange method (weak argument)
- it's in 6.1ocb, so an upgrade to 7.0ocb would break existing functionality (strong argument)