Merge lp:~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults into lp:ocb-addons

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 9731
Proposed branch: lp:~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults
Merge into: lp:ocb-addons
Diff against target: 38 lines (+3/-3)
3 files modified
email_template/res_partner.py (+1/-1)
mail/res_partner.py (+1/-1)
mail/tests/test_mail_features.py (+1/-1)
To merge this branch: bzr merge lp:~therp-nl/ocb-addons/7.0-lp1249600-reverse_ocb_email_defaults
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Guewen Baconnier @ Camptocamp Approve
Daniel Reis (community) Approve
Stéphane Bidoul (Acsone) (community) Approve
Review via email: mp+194621@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stéphane Bidoul (Acsone) (sbi) wrote :

Thanks for the MP. May I suggest to revert the test too (rev 9624)?

-sbi

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks Stéphane for pointing that out! Done that now.

Revision history for this message
Stéphane Bidoul (Acsone) (sbi) :
review: Approve
Revision history for this message
Daniel Reis (dreis-pt) :
review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'email_template/res_partner.py'
--- email_template/res_partner.py 2013-08-15 07:54:23 +0000
+++ email_template/res_partner.py 2013-11-09 14:36:29 +0000
@@ -34,7 +34,7 @@
34 }34 }
3535
36 _defaults = {36 _defaults = {
37 'opt_out': True,37 'opt_out': False,
38 }38 }
3939
40# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:40# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
4141
=== modified file 'mail/res_partner.py'
--- mail/res_partner.py 2013-08-15 07:54:23 +0000
+++ mail/res_partner.py 2013-11-09 14:36:29 +0000
@@ -43,7 +43,7 @@
43 }43 }
4444
45 _defaults = {45 _defaults = {
46 'notification_email_send': lambda *args: 'none'46 'notification_email_send': lambda *args: 'comment'
47 }47 }
4848
49 def message_get_suggested_recipients(self, cr, uid, ids, context=None):49 def message_get_suggested_recipients(self, cr, uid, ids, context=None):
5050
=== modified file 'mail/tests/test_mail_features.py'
--- mail/tests/test_mail_features.py 2013-10-27 15:03:16 +0000
+++ mail/tests/test_mail_features.py 2013-11-09 14:36:29 +0000
@@ -237,7 +237,7 @@
237 self.res_users.write(cr, uid, [uid], {'email': 'a@a', 'notification_email_send': 'comment'})237 self.res_users.write(cr, uid, [uid], {'email': 'a@a', 'notification_email_send': 'comment'})
238 self.res_users.write(cr, uid, [self.user_raoul_id], {'email': 'r@r'})238 self.res_users.write(cr, uid, [self.user_raoul_id], {'email': 'r@r'})
239 # 1 - Bert Tartopoils, with email, should receive emails for comments and emails239 # 1 - Bert Tartopoils, with email, should receive emails for comments and emails
240 p_b_id = self.res_partner.create(cr, uid, {'name': 'Bert Tartopoils', 'email': 'b@b', 'notification_email_send': 'comment'})240 p_b_id = self.res_partner.create(cr, uid, {'name': 'Bert Tartopoils', 'email': 'b@b'})
241 # 2 - Carine Poilvache, with email, should receive emails for emails241 # 2 - Carine Poilvache, with email, should receive emails for emails
242 p_c_id = self.res_partner.create(cr, uid, {'name': 'Carine Poilvache', 'email': 'c@c', 'notification_email_send': 'email'})242 p_c_id = self.res_partner.create(cr, uid, {'name': 'Carine Poilvache', 'email': 'c@c', 'notification_email_send': 'email'})
243 # 3 - Dédé Grosbedon, without email, to test email verification; should receive emails for every message243 # 3 - Dédé Grosbedon, without email, to test email verification; should receive emails for every message