Merge lp:~therp-nl/banking-addons/girotel_structured_description into lp:banking-addons/6.1

Proposed by Holger Brunn (Therp)
Status: Merged
Merged at revision: 177
Proposed branch: lp:~therp-nl/banking-addons/girotel_structured_description
Merge into: lp:banking-addons/6.1
Diff against target: 34 lines (+10/-0)
1 file modified
account_banking_nl_girotel/girotel.py (+10/-0)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/girotel_structured_description
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review, no test Approve
Stefan Rijnhart (Opener) Approve
Review via email: mp+168453@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

lgtm

review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_banking_nl_girotel/girotel.py'
--- account_banking_nl_girotel/girotel.py 2012-07-09 17:04:14 +0000
+++ account_banking_nl_girotel/girotel.py 2013-06-10 13:58:27 +0000
@@ -46,6 +46,7 @@
46from account_banking.parsers.convert import str2date, to_swift46from account_banking.parsers.convert import str2date, to_swift
47from tools.translate import _47from tools.translate import _
48import csv48import csv
49import re
4950
50bt = models.mem_bank_transaction51bt = models.mem_bank_transaction
5152
@@ -143,6 +144,10 @@
143 'VZ': bt.PAYMENT_BATCH,144 'VZ': bt.PAYMENT_BATCH,
144 }145 }
145146
147 structured_description_regex = re.compile(
148 '^IBAN: (?P<iban>\w+) BIC: (?P<bic>\w+) Naam: (?P<name>.+) '
149 'Omschrijving: (?P<desc>.+)$')
150
146 def __init__(self, line, *args, **kwargs):151 def __init__(self, line, *args, **kwargs):
147 '''152 '''
148 Initialize own dict with read values.153 Initialize own dict with read values.
@@ -274,6 +279,11 @@
274 # Normal transaction, but remote_owner can contain city, depending279 # Normal transaction, but remote_owner can contain city, depending
275 # on length of total. As there is no clear pattern, leave it as280 # on length of total. As there is no clear pattern, leave it as
276 # is.281 # is.
282 structured_description = self.structured_description_regex.match(
283 ''.join(self.message.split('\n')))
284 if structured_description:
285 values = structured_description.groupdict()
286 self.reference = values['desc']
277 self.message = self.refold_message(self.message)287 self.message = self.refold_message(self.message)
278288
279 else:289 else:

Subscribers

People subscribed via source and target branches