Merge lp:~therp-nl/banking-addons/ba70-partner_model_fixes into lp:banking-addons

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 195
Proposed branch: lp:~therp-nl/banking-addons/ba70-partner_model_fixes
Merge into: lp:banking-addons
Diff against target: 86 lines (+16/-10)
4 files modified
account_banking/banking_import_transaction.py (+1/-1)
account_banking/wizard/banking_transaction_wizard.py (+4/-4)
account_banking/wizard/banktools.py (+7/-4)
account_banking/wizard/link_partner.py (+4/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba70-partner_model_fixes
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Review via email: mp+185630@code.launchpad.net
To post a comment you must log in.
187. By Stefan Rijnhart (Opener)

[FIX] Partner <> parent confusion

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py 2013-08-24 10:57:32 +0000
+++ account_banking/banking_import_transaction.py 2013-09-23 09:10:28 +0000
@@ -72,7 +72,7 @@
72 invoice_ids = invoice_obj.search(cr, uid, [72 invoice_ids = invoice_obj.search(cr, uid, [
73 '&',73 '&',
74 ('type', '=', 'in_invoice'),74 ('type', '=', 'in_invoice'),
75 ('partner_id', '=', account_info.bank_partner_id.id),75 ('partner_id', 'child_of', account_info.bank_partner_id.id),
76 ('company_id', '=', account_info.company_id.id),76 ('company_id', '=', account_info.company_id.id),
77 ('date_invoice', '=', trans.effective_date),77 ('date_invoice', '=', trans.effective_date),
78 ('reference', '=', reference),78 ('reference', '=', reference),
7979
=== modified file 'account_banking/wizard/banking_transaction_wizard.py'
--- account_banking/wizard/banking_transaction_wizard.py 2013-08-12 09:20:35 +0000
+++ account_banking/wizard/banking_transaction_wizard.py 2013-09-23 09:10:28 +0000
@@ -131,7 +131,7 @@
131 { 'move_line_id': move_line.id, }, context=context)131 { 'move_line_id': move_line.id, }, context=context)
132 statement_line_obj.write(132 statement_line_obj.write(
133 cr, uid, wiz.import_transaction_id.statement_line_id.id,133 cr, uid, wiz.import_transaction_id.statement_line_id.id,
134 { 'partner_id': move_line.invoice.partner_id.id,134 { 'partner_id': move_line.partner_id.id or False,
135 'account_id': move_line.account_id.id,135 'account_id': move_line.account_id.id,
136 }, context=context)136 }, context=context)
137 found = True137 found = True
@@ -226,9 +226,9 @@
226 }226 }
227227
228 if todo_entry[0]:228 if todo_entry[0]:
229 st_line_vals['partner_id'] = invoice_obj.read(229 st_line_vals['partner_id'] = invoice_obj.browse(
230 cr, uid, todo_entry[0], 230 cr, uid, todo_entry[0], context=context
231 ['partner_id'], context=context)['partner_id'][0]231 ).partner_id.commercial_partner_id.id
232232
233 statement_line_obj.write(233 statement_line_obj.write(
234 cr, uid, statement_line_id, 234 cr, uid, statement_line_id,
235235
=== modified file 'account_banking/wizard/banktools.py'
--- account_banking/wizard/banktools.py 2013-06-04 10:18:31 +0000
+++ account_banking/wizard/banktools.py 2013-09-23 09:10:28 +0000
@@ -97,8 +97,11 @@
97 TODO: revive the search by lines from the address argument97 TODO: revive the search by lines from the address argument
98 '''98 '''
99 partner_obj = pool.get('res.partner')99 partner_obj = pool.get('res.partner')
100 partner_ids = partner_obj.search(cr, uid, [('name', 'ilike', name)],100 partner_ids = partner_obj.search(
101 context=context)101 cr, uid, [
102 '|', ('is_company', '=', True), ('parent_id', '=', False),
103 ('name', 'ilike', name),
104 ], context=context)
102 if not partner_ids:105 if not partner_ids:
103 # Try brute search on address and then match reverse106 # Try brute search on address and then match reverse
104 criteria = []107 criteria = []
@@ -118,11 +121,11 @@
118 key = name.lower()121 key = name.lower()
119 partners = []122 partners = []
120 for partner in partner_obj.read(123 for partner in partner_obj.read(
121 cr, uid, partner_search_ids, ['name'], context=context):124 cr, uid, partner_search_ids, ['name', 'commercial_partner_id'], context=context):
122 if (len(partner['name']) > 3 and partner['name'].lower() in key):125 if (len(partner['name']) > 3 and partner['name'].lower() in key):
123 partners.append(partner)126 partners.append(partner)
124 partners.sort(key=lambda x: len(x['name']), reverse=True)127 partners.sort(key=lambda x: len(x['name']), reverse=True)
125 partner_ids = [x['id'] for x in partners]128 partner_ids = [x['commercial_partner_id'][0] for x in partners]
126 if len(partner_ids) > 1:129 if len(partner_ids) > 1:
127 log.append(130 log.append(
128 _('More than one possible match found for partner with '131 _('More than one possible match found for partner with '
129132
=== modified file 'account_banking/wizard/link_partner.py'
--- account_banking/wizard/link_partner.py 2013-06-05 12:34:24 +0000
+++ account_banking/wizard/link_partner.py 2013-09-23 09:10:28 +0000
@@ -34,7 +34,10 @@
34 'supplier': fields.boolean('Supplier'),34 'supplier': fields.boolean('Supplier'),
35 'customer': fields.boolean('Customer'),35 'customer': fields.boolean('Customer'),
36 'partner_id': fields.many2one(36 'partner_id': fields.many2one(
37 'res.partner', 'or link existing partner'),37 'res.partner', 'or link existing partner',
38 domain=['|', ('is_company', '=', True),
39 ('parent_id', '=', False)],
40 ),
38 'statement_line_id': fields.many2one(41 'statement_line_id': fields.many2one(
39 'account.bank.statement.line',42 'account.bank.statement.line',
40 'Statement line', required=True),43 'Statement line', required=True),

Subscribers

People subscribed via source and target branches

to status/vote changes: