Merge lp:~therp-nl/banking-addons/ba70-lp1246642 into lp:banking-addons

Proposed by Stefan Rijnhart (Opener)
Status: Rejected
Rejected by: Stefan Rijnhart (Opener)
Proposed branch: lp:~therp-nl/banking-addons/ba70-lp1246642
Merge into: lp:banking-addons
Diff against target: 18 lines (+7/-1)
1 file modified
account_banking/banking_import_transaction.py (+7/-1)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/ba70-lp1246642
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+193396@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I'm retracting this proposal as the server bug should be fixed by this commit: http://bazaar.launchpad.net/~openerp/openobject-server/7.0/revision/5136

Unmerged revisions

203. By Stefan Rijnhart (Opener)

[FIX] AccessError on confirming bank statements of a child company
 (Workaround for lp:1246642)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py 2013-10-14 12:33:57 +0000
+++ account_banking/banking_import_transaction.py 2013-10-31 10:13:29 +0000
@@ -1602,7 +1602,13 @@
1602 if st_line.import_transaction_id:1602 if st_line.import_transaction_id:
1603 import_transaction_obj.confirm(1603 import_transaction_obj.confirm(
1604 cr, uid, st_line.import_transaction_id.id, context)1604 cr, uid, st_line.import_transaction_id.id, context)
1605 st_line.refresh()1605 # Workaround for
1606 # https://bugs.launchpad.net/openobject-server/+bug/1238042
1607 # Need to rebrowse instead of refresh, because any parent company
1608 # will be in the browse record's id cache after the first pass, and
1609 # accessing the actual company will then trigger a read attempt on
1610 # the inaccessible parent company too, leading to an access error.
1611 st_line = self.browse(cr, uid, st_line.id, context=context)
1606 st_line_number = statement_pool.get_next_st_line_number(1612 st_line_number = statement_pool.get_next_st_line_number(
1607 cr, uid, st_number, st_line, context)1613 cr, uid, st_number, st_line, context)
1608 company_currency_id = st.journal_id.company_id.currency_id.id1614 company_currency_id = st.journal_id.company_id.currency_id.id

Subscribers

People subscribed via source and target branches

to status/vote changes: