Code review comment for lp:~therp-nl/banking-addons/ba70-lp1231174-default_method_should_not_raise_at_module_installation_time

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Pedro,

thank you for the review! I know that osv.except_osv is deprecated, but this is what account_period.find() raises, so that is what I have to catch.

I actually prefer the test for context is None, otherwise I am reconstructing an empty dictionary even if the passed context is already an empty dictionary.

If date is False, account_period.find() returns the period of the current date, so I can't refactor according to your suggestion.

« Back to merge proposal