Code review comment for lp:~therp-nl/banking-addons/ba70-lp1231174-default_method_should_not_raise_at_module_installation_time

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Another thing: if date is False, has any meaning to call "self.pool.get('account.period').find(cr, uid, dt=date, context=local_ctx)[0]"?

If not, I would refactor this to:

if not date:
    return False
else:
    self.pool.get('account.period').find...

And I suppose that the try is not neccessary in this case...

review: Needs Information (code review, no test)

« Back to merge proposal