Banking Addons

Code review comment for lp:~therp-nl/banking-addons/ba70-deprecate_iban_lookup

  1. ba70-deprecate_iban_lookup
  2. Merge into banking-addons-70
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

You should remove unused import from account_banking.

account_banking/account_banking.py|68 col 1| F401 'SUPERUSER_ID' imported but unused
account_banking/account_banking.py|70 col 1| F401 'sepa' imported but unused
account_banking/account_banking.py|71 col 1| F401 'get_or_create_bank' imported but unused

Plus I had a conflict on account_banking.py on removals of res_partner_bank and res_bank classes. Can you check that and if needed merge main branch in here to solve it.

review: Needs Fixing (code review)

« Back to merge proposal