Code review comment for lp:~therp-nl/banking-addons/ba7.0-RFR-split_off_payment_part

Hi Alexandre,

thanks for taking the effort of ploughing through this monstrous diff!

Your first point is very good, but there is nothing that I can do about that. The list of fields on the payment model is merely there to add an entry to their 'states' list. In order to do so, I need to duplicate the earlier definitions from the account_payment module. The errors that you point out in field names and help texts are in that module. I wish it was easier to change this field attribute (and it would be if the orm did not lump attrs from the 'states' list and the 'attrs' dictionary together with the implicit 'AND' operator, lp:941901).

Other changes agreed and processed.