Code review comment for lp:~therp-nl/banking-addons/ba7.0-MIG-import
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
review:
Needs Fixing
(code review, no test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I'm really not fond of "import *" in production code, especially if, as in here, there several such imports in the same module.
I suggest:
* either importing explicitely the symbols you are using
* of importing just the module (maybe with the "as" keyword to perform an on the fly aliasing) and using a qualified access
Question: what do the "AB" comments stand for?