Code review comment for lp:~therp-nl/banking-addons/ba61-multicompany_safe_partner_search

Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

Approve LGTM

One other idea;
If multiple names are found, maybe better to take the longest, instead of the first?

Lets assume we have the following partner names:
Smith
Smithsonian
Smithsons

The function is passed the name Smithsons Ltd.

None of the partner names is ilike Smithsons Ltd., so we have to do a brute force search.
This will eliminate Smithsonian (not in Smithsons Ltd.)

Then Smithsons would seem to be the better match.

review: Approve

« Back to merge proposal