Merge lp:~therp-nl/banking-addons/7.0-view_error_direct_debit into lp:banking-addons

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 182
Proposed branch: lp:~therp-nl/banking-addons/7.0-view_error_direct_debit
Merge into: lp:banking-addons
Diff against target: 19 lines (+2/-2)
1 file modified
account_direct_debit/view/account_payment.xml (+2/-2)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/7.0-view_error_direct_debit
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+176790@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_direct_debit/view/account_payment.xml'
--- account_direct_debit/view/account_payment.xml 2013-05-28 15:18:26 +0000
+++ account_direct_debit/view/account_payment.xml 2013-07-24 21:20:36 +0000
@@ -32,13 +32,13 @@
32 <field name="reference" position="after">32 <field name="reference" position="after">
33 <field name="payment_order_type"/>33 <field name="payment_order_type"/>
34 </field>34 </field>
35 <xpath expr="/form/group/button[@string='Select Invoices to Pay']"35 <xpath expr="//button[@string='Select Invoices to Pay']"
36 position="attributes">36 position="attributes">
37 <attribute name="attrs">37 <attribute name="attrs">
38 {'invisible':['|',('state','!=','draft'),('payment_order_type', '!=', 'payment')]}38 {'invisible':['|',('state','!=','draft'),('payment_order_type', '!=', 'payment')]}
39 </attribute>39 </attribute>
40 </xpath>40 </xpath>
41 <xpath expr="/form/group/button[@string='Select Invoices to Pay']"41 <xpath expr="//button[@string='Select Invoices to Pay']"
42 position="after">42 position="after">
43 <button colspan="2" name="%(account_payment.action_create_payment_order)s"43 <button colspan="2" name="%(account_payment.action_create_payment_order)s"
44 string="Select Invoices to Collect" type="action" 44 string="Select Invoices to Collect" type="action"

Subscribers

People subscribed via source and target branches

to status/vote changes: