Merge lp:~therp-nl/banking-addons/7.0-undefined_variables_ref_msg into lp:banking-addons

Proposed by Stefan Rijnhart (Opener)
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 216
Merged at revision: 217
Proposed branch: lp:~therp-nl/banking-addons/7.0-undefined_variables_ref_msg
Merge into: lp:banking-addons
Diff against target: 15 lines (+2/-2)
1 file modified
account_banking/banking_import_transaction.py (+2/-2)
To merge this branch: bzr merge lp:~therp-nl/banking-addons/7.0-undefined_variables_ref_msg
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+201293@code.launchpad.net

Description of the change

A recent change revealed a bug in a code path that was never reached before, in which two variables are referenced that are not available in that code path.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) :
review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) :
review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py 2014-01-06 11:59:22 +0000
+++ account_banking/banking_import_transaction.py 2014-01-11 16:13:27 +0000
@@ -255,9 +255,9 @@
255 # creation. This also enables us to search for the invoice number in the255 # creation. This also enables us to search for the invoice number in the
256 # reference instead of the other way around, as most human interventions256 # reference instead of the other way around, as most human interventions
257 # *add* text.257 # *add* text.
258 ref = trans.reference.upper()
259 msg = trans.message.upper()
258 if len(candidates) > 1 or not candidates:260 if len(candidates) > 1 or not candidates:
259 ref = trans.reference.upper()
260 msg = trans.message.upper()
261 # The manual usage of the sales journal creates moves that261 # The manual usage of the sales journal creates moves that
262 # are not tied to invoices. Thanks to Stefan Rijnhart for262 # are not tied to invoices. Thanks to Stefan Rijnhart for
263 # reporting this.263 # reporting this.

Subscribers

People subscribed via source and target branches

to status/vote changes: