Code review comment for lp:~therp-nl/banking-addons/7.0-abnamro-sepa_type_case
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks for the review!
I would always go for the latter in cases like:
bar = foo.get('bar')
if bar:
...
But as I was going to run a string operation on the result, I didn't want to run the risk of sepa_dict containing a key 'TRTP' with value False (even if the preceding code currently seems to guarantee that when sepa_dict contains a key 'TRTP', the value will always be a string)