Code review comment for lp:~therp-nl/banking-addons/6.1-account_banking_nl_ing_mt940

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Awesome, finally a generic MT940 parser!

Just two comments from code review, I'll do some testing later on:
- l.122 You might want to add a comment that the exception handling here allows you to execute the file to test the parser outside the context of the OpenERP server (I think).
- l.165 Quite a fashion statement ;-) I know this runs, but you might want to either add two single quotes at the start or remove two at the end so that it looks like a regular docstring.

review: Needs Fixing

« Back to merge proposal