Code review comment for lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear
Revision history for this message
| Leonardo Pistone (lepistone) wrote | # |
review:
Needs Fixing
(code review)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Holger,
It looks good, with a few small remarks:
* I would expand further the description in __openerp__.py, stating explicitly that we are overriding the existing report from the account module. Furthermore: apart from the period, the query is the same as the account module? Maybe a link to the bug?
* read_group could benefit from a docstring to explain what is going on.
* flake8 shows some issues, like spaces before colons and eigth-space indentation.
Thanks for your work