Code review comment for lp:~themuso/indicator-applet/accessible-desc

On Thu, Feb 17, 2011 at 10:01:20AM EST, Ted Gould wrote:
> I'm not sure why we need to update the entry here, it seems that should
> be done internally in the IndicatorObject no?

Not all indicators have their own get_entries method, i.e messages, sound, session, me, datetime, and they don't even deal with their entry data directly, rather the get_ methods are used to retrieve that info for libindicator to fill in.

On the above understanding, I am trying to take care of the cases where indicators that have a get_entries method and do not have a get_accessible_desc method, ala indicator-application, can still get the accessible_desc variable updated.

If its better that indicator-application also be extended to have a get_accessible_desc method, then I can do that too, and that code can be changed.

Luke