Code review comment for lp:~themuso/indicator-applet/accessible-desc

Revision history for this message
Ted Gould (ted) wrote :

On Mon, 2011-02-14 at 03:46 +0000, Luke Yelavich wrote:
> + /* Not all indicator entries have a get_accessible_desc method, such as
> + indicator-application entries */
> + if (class->get_accessible_desc != NULL) {
> + entry->accessible_desc = class->get_accessible_desc(io);
> + }

I'm not sure why we need to update the entry here, it seems that should
be done internally in the IndicatorObject no?

  review needsinformation

review: Needs Information

« Back to merge proposal