Code review comment for lp:~themue/pyjuju/go-state-unit-resolved-watcher
Revision history for this message
| Gustavo Niemeyer (niemeyer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On 2012/04/24 10:01:51, TheMue wrote:
> A review comment of William for this proposal has been that the
handling of
> "needs upgrade" is outdated due to a change of the Python code. Do I
understand
> you right that you now want me to roll the changes back to the old
> implementation and create an extra change for it?
Oh, so an unrelated change to the needs-upgrade functionality was merged
in purposefully?
This is still the same topic we talked about back at the Rally in
Budapest: changes should be self-contained. Fixing the NeedsUpgrades
behavior is definitely not part of what this CL is supposed to be
covering. From its summary:
"""
Added ResolvedWatcher for Units.
It reads the resolved mode out of the node content if
it's created or changed.
"""
If you get a review comment from someone suggesting unrelated changes
and you agree with them, just put that in another branch and move on.
https:/