Code review comment for lp:~themue/juju-core/go-worker-firewaller-machines

Gustavo Niemeyer (niemeyer) wrote :

https://codereview.appspot.com/6374069/diff/8001/worker/firewaller/firewaller.go
File worker/firewaller/firewaller.go (right):

https://codereview.appspot.com/6374069/diff/8001/worker/firewaller/firewaller.go#newcode52
worker/firewaller/firewaller.go:52: if err != nil {
On 2012/07/17 17:26:24, rog wrote:
> On 2012/07/17 16:13:50, niemeyer wrote:
> > I believe we want to execute the line below no matter what. The err
is nil,
> the
> > MustErr is supposed to explode pointing out the inconsistency.

> in fact, if there's EOF from the machinesWatcher, it implies that the
machines
> watcher has already stopped, so there's no need to call Stop.

Good point.

https://codereview.appspot.com/6374069/

« Back to merge proposal