https://codereview.appspot.com/6374069/diff/8001/worker/firewaller/firewaller.go#newcode52
worker/firewaller/firewaller.go:52: if err != nil {
On 2012/07/17 17:26:24, rog wrote:
> On 2012/07/17 16:13:50, niemeyer wrote:
> > I believe we want to execute the line below no matter what. The err
is nil,
> the
> > MustErr is supposed to explode pointing out the inconsistency.
> in fact, if there's EOF from the machinesWatcher, it implies that the
machines
> watcher has already stopped, so there's no need to call Stop.
https:/ /codereview. appspot. com/6374069/ diff/8001/ worker/ firewaller/ firewaller. go firewaller/ firewaller. go (right):
File worker/
https:/ /codereview. appspot. com/6374069/ diff/8001/ worker/ firewaller/ firewaller. go#newcode52 firewaller/ firewaller. go:52: if err != nil {
worker/
On 2012/07/17 17:26:24, rog wrote:
> On 2012/07/17 16:13:50, niemeyer wrote:
> > I believe we want to execute the line below no matter what. The err
is nil,
> the
> > MustErr is supposed to explode pointing out the inconsistency.
> in fact, if there's EOF from the machinesWatcher, it implies that the
machines
> watcher has already stopped, so there's no need to call Stop.
Good point.
https:/ /codereview. appspot. com/6374069/