Code review comment for lp:~themue/juju-core/go-state-unit-status

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

LGTM with trivials:

https://codereview.appspot.com/6454113/diff/9004/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6454113/diff/9004/state/unit.go#newcode173
state/unit.go:173: func (u *Unit) Status() (UnitStatus, string, error) {
(s UnitStatus, info string, err error)

https://codereview.appspot.com/6454113/diff/9004/state/unit.go#newcode176
state/unit.go:176: return "", "", err
return "", "", fmt.Errorf("cannot read status of unit %q: %v", u, err)

https://codereview.appspot.com/6454113/diff/9004/state/unit.go#newcode188
state/unit.go:188: panic("no status-info for unit error found")
"no status-info found for unit error"

https://codereview.appspot.com/6454113/diff/9004/state/unit.go#newcode217
state/unit.go:217: return fmt.Errorf("cannot set status of %q: %v", u,
err)
s/of/of unit/

https://codereview.appspot.com/6454113/

« Back to merge proposal