Code review comment for lp:~themue/juju-core/go-state-unit-status

Revision history for this message
William Reade (fwereade) wrote :

LGTM, couple of trivials.

https://codereview.appspot.com/6454113/diff/8005/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6454113/diff/8005/state/unit.go#newcode54
state/unit.go:54: // UnitInfo allows to add an additional info, e.g. an
error reason
s/an //

https://codereview.appspot.com/6454113/diff/8005/state/unit.go#newcode185
state/unit.go:185: // Status returns the status of the unit's agent
s/agent/agent./

https://codereview.appspot.com/6454113/diff/8005/state/unit.go#newcode199
state/unit.go:199: // We allways expect an info if status is 'error'.
s/allways/always.

https://codereview.appspot.com/6454113/diff/8005/state/unit.go#newcode220
state/unit.go:220: func (u *Unit) SetStatus(status UnitStatus, info
string) error {
Maybe a check that we're not setting "pending", which is guaranteed
crack.

https://codereview.appspot.com/6454113/

« Back to merge proposal