Code review comment for lp:~themue/juju-core/go-state-unit-status

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

https://codereview.appspot.com/6454113/diff/3001/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6454113/diff/3001/state/unit.go#newcode160
state/unit.go:160: // Status returns the status of the unit.
The whole thing is looking good, but it's missing more context of what
this is. What does "status of the unit" actually mean? What are the set
of valid values? Should these be constants? etc.

https://codereview.appspot.com/6454113/diff/3001/state/unit.go#newcode162
state/unit.go:162: status, err := getConfigString(u.st.zk, u.zkPath(),
"status", "status of unit %q", u)
We've conventionally agreed to break the line down before the
description (see the rest).

https://codereview.appspot.com/6454113/

« Back to merge proposal