Code review comment for lp:~themue/juju-core/go-state-lifecycle-relation

Revision history for this message
Aram Hăvărneanu (aramh) wrote :

https://codereview.appspot.com/6455065/diff/1/state/lifecycle.go
File state/lifecycle.go (right):

https://codereview.appspot.com/6455065/diff/1/state/lifecycle.go#newcode9
state/lifecycle.go:9: type Life string
Hmm, this simplifies returning errors, but the integer approach in
mstate makes state change checking trivial because all you need to do is

   if (newLife < life) { ...

https://codereview.appspot.com/6455065/

« Back to merge proposal