juju-core

Code review comment for lp:~themue/juju-core/032-config-default-empty-string

  1. 032-config-default-empty-string
  2. Merge into trunk
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

LGTM

https://codereview.appspot.com/10682043/diff/8001/charm/config.go
File charm/config.go (right):

https://codereview.appspot.com/10682043/diff/8001/charm/config.go#newcode114
charm/config.go:114: if def == "" && option.Type == "string" {
much nicer, thanks!

https://codereview.appspot.com/10682043/

« Back to merge proposal