LGTM with updated doc comment and better tests.
https://codereview.appspot.com/10266043/diff/1/worker/resumer/resumer.go File worker/resumer/resumer.go (right):
https://codereview.appspot.com/10266043/diff/1/worker/resumer/resumer.go#newcode23 worker/resumer/resumer.go:23: // NewResumer ... ... ?
https://codereview.appspot.com/10266043/diff/1/worker/resumer/resumer.go#newcode57 worker/resumer/resumer.go:57: log.Errorf("worker/resumer: cannot resume transactions: %v", err) to be consistent with the other workers, this error would be fatal. any particular reason why it's not?
https://codereview.appspot.com/10266043/diff/1/worker/resumer/resumer_test.go File worker/resumer/resumer_test.go (right):
https://codereview.appspot.com/10266043/diff/1/worker/resumer/resumer_test.go#newcode25 worker/resumer/resumer_test.go:25: rr := resumer.NewResumer(s.State) how does this test that ResumeTransactions is actually called? (given that it actually isn't in this test)
https://codereview.appspot.com/10266043/
« Back to merge proposal
LGTM with updated doc comment and better tests.
https:/ /codereview. appspot. com/10266043/ diff/1/ worker/ resumer/ resumer. go resumer/ resumer. go (right):
File worker/
https:/ /codereview. appspot. com/10266043/ diff/1/ worker/ resumer/ resumer. go#newcode23 resumer/ resumer. go:23: // NewResumer ...
worker/
... ?
https:/ /codereview. appspot. com/10266043/ diff/1/ worker/ resumer/ resumer. go#newcode57 resumer/ resumer. go:57: log.Errorf( "worker/ resumer: cannot resume
worker/
transactions: %v", err)
to be consistent with the other workers, this error would be fatal.
any particular reason why it's not?
https:/ /codereview. appspot. com/10266043/ diff/1/ worker/ resumer/ resumer_ test.go resumer/ resumer_ test.go (right):
File worker/
https:/ /codereview. appspot. com/10266043/ diff/1/ worker/ resumer/ resumer_ test.go# newcode25 resumer/ resumer_ test.go: 25: rr := resumer. NewResumer( s.State)
worker/
how does this test that ResumeTransactions is actually called? (given
that it actually isn't in this test)
https:/ /codereview. appspot. com/10266043/