Code review comment for lp:~themue/juju-core/024-cleanup-watcher
Revision history for this message
| Frank Mueller (themue) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
*** Submitted:
state: added CleanupWatcher
The CleanupWatcher signals the demand for the running of
state.Cleanup(). It is the first in a row of CLs to add
an according worker.
R=fwereade, dimitern
CC=
https:/
https:/
File state/state_test.go (right):
https:/
state/state_
On 2013/06/07 12:24:50, dimitern wrote:
> please change this to say "unexpected change; ok: %v"
Done.
https:/
state/state_
On 2013/06/07 12:24:50, dimitern wrote:
> // Adding relations doesn't emit events.
Done.
https:/
state/state_
On 2013/06/07 12:24:50, dimitern wrote:
> // Verify that Cleanup() doesn't emit unnecessary events.
Done.
https:/
state/state_
queue. Cleanups
On 2013/06/07 12:24:50, dimitern wrote:
> // Not calling Cleanup() queues up the changes, so that
> // multiple changes will be emitted the next time Cleanup()
> // is called. This behavior will change in a follow-up.
That's not correct, the second part is related to the internal behavior
of Cleanup() with individual transactions per deletion. Will separate
this better.
https:/
File state/watcher.go (right):
https:/
state/watcher.
documents
On 2013/06/07 12:24:50, dimitern wrote:
> // CleanupWatcher notifies of changes in the cleanups collection.
> ?
Done.
https:/
state/watcher.
notifies when documents
On 2013/06/07 12:24:50, dimitern wrote:
> // WatchCleanups starts and returns a CleanupWatcher.
Done.
https:/