LGTM wrt output. Code improvements appreciated but not required.
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status.go File cmd/juju/status.go (right):
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status.go#newcode214 cmd/juju/status.go:214: delete(servicesMap[serviceName].(statusMap), "units") I remain suspicious of this, but the output looks sane, we can worry about this another day.
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status.go#newcode283 cmd/juju/status.go:283: subTo = subToMap[svcName].([]string) Why are we doing this over and over again for every unit?
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status_test.go File cmd/juju/status_test.go (right):
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status_test.go#newcode610 cmd/juju/status_test.go:610: "agent-state-info": "somehow lost in all those logs", :)
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status_test.go#newcode780 cmd/juju/status_test.go:780: s, err := ctx.st.Service(sua.serviceName) Do we have anything for testing non-agent-alive units?
https://codereview.appspot.com/8824043/diff/6001/cmd/juju/status_test.go#newcode842 cmd/juju/status_test.go:842: rel, err := ctx.st.AddRelation(eps...) Please don't do this. Create the relation separately, and get it here with Relation.
https://codereview.appspot.com/8824043/
« Back to merge proposal
LGTM wrt output. Code improvements appreciated but not required.
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status. go
File cmd/juju/status.go (right):
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status. go#newcode214 status. go:214: delete( servicesMap[ serviceName] .(statusMap) ,
cmd/juju/
"units")
I remain suspicious of this, but the output looks sane, we can worry
about this another day.
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status. go#newcode283 status. go:283: subTo = subToMap[ svcName] .([]string)
cmd/juju/
Why are we doing this over and over again for every unit?
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status_ test.go status_ test.go (right):
File cmd/juju/
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status_ test.go# newcode610 status_ test.go: 610: "agent-state-info": "somehow lost in all
cmd/juju/
those logs",
:)
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status_ test.go# newcode780 status_ test.go: 780: s, err := ctx.st. Service( sua.serviceName )
cmd/juju/
Do we have anything for testing non-agent-alive units?
https:/ /codereview. appspot. com/8824043/ diff/6001/ cmd/juju/ status_ test.go# newcode842 status_ test.go: 842: rel, err := ctx.st. AddRelation( eps...)
cmd/juju/
Please don't do this. Create the relation separately, and get it here
with Relation.
https:/ /codereview. appspot. com/8824043/