Merge lp:~thelinuxguy/openlp/fix-version-check into lp:openlp
Proposed by
Simon Hanna
Status: | Merged |
---|---|
Merged at revision: | 2805 |
Proposed branch: | lp:~thelinuxguy/openlp/fix-version-check |
Merge into: | lp:openlp |
Diff against target: |
110 lines (+34/-10) 3 files modified
.bzrignore (+1/-0) openlp/core/version.py (+4/-6) tests/functional/openlp_core/test_version.py (+29/-4) |
To merge this branch: | bzr merge lp:~thelinuxguy/openlp/fix-version-check |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Bentley | Approve | ||
Raoul Snyman | Approve | ||
Review via email: mp+335602@code.launchpad.net |
Description of the change
Fixed the version checking to be more robust
* Strip the response so empty responses that contain whitespace are in fact empty
* Change http to https to result in one less query
* Add test for responses containing white space
* Add .cache to bzrignore (generated by pytest when tests fail)
To post a comment you must log in.
Looks good to me.