lp:~thelinuxguy/openlp/editable-remote-port

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp:openlp

Raoul Snyman: Approve on 2018-08-22

Tim Bentley: Disapprove on 2018-08-22

Diff: 67 lines (+31/-3)

2 files modified

openlp/core/api/tab.py (+7/-3)
tests/functional/openlp_core/api/test_tab.py (+24/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2830. By Simon Hanna on 2018-08-22

Make Remote Port editable again

2829. By Simon Hanna on 2018-08-18

Instead of raising an error when converting paths, return None and log an error.

The method is allowed to return None, so calling functions should handle that. Raising an error is very rude behavior and the output just said that the input was invalid with no real clue as to what is wrong.

Now None is returned without causing too much hassle, and a proper error is logged mentioning what exactly caused the error.

The test case was updated.

This is sort of related to https://bugs.launchpad.net/openlp/+bug/1786601 in that this would have been nice to actually know what went wrong and failback to None.

2828. By Tomas Groth on 2018-08-05

Fix some pylint failures and add qtawesome to appveyor install.

2827. By Tomas Groth on 2018-08-04

Update resource file

2826. By Tim Bentley on 2018-08-04

Replaced png icons with fonts
Added ability to have custom fonts

2825. By Ken Roberts on 2018-08-04

Fix windows not naming localhost interface to lo

2824. By Tomas Groth on 2018-08-03

Workaround for bazaar no longer working on appveyor. We now download a tarball instead of checking out the code.

2823. By Phill on 2018-07-12

Add cetralised proxy support

2822. By Tomas Groth on 2018-07-07

Fix pep8 and pylint errors detected by new version.

2821. By Ken Roberts on 2018-06-28

PJLink2 update S