Code review comment for lp:~theiw/txstatsd/deprecate-meter

Revision history for this message
Lucio Torre (lucio.torre) wrote :

 946 + metric = [float(v) for v in values]
 947 + metric.append(key)

 that code seems to imply that the contents of metric could be *values, key
 when in reality it has to be [value, key]
 so maybe it can be replaced with a one liner: metric = [ float(value[0]), key]

review: Approve

« Back to merge proposal